PMD Results

The following document contains the results of PMD.

Summary

Files Errors
54 80

Files

Files Violations
org/figure8/join/businessobjects/security/persistence/JdbcUserDao.java 1
org/figure8/join/control/AccessControlFilter.java 1
org/figure8/join/control/DownloadServlet.java 3
org/figure8/join/control/I18nStrutsBundleAdapter.java 2
org/figure8/join/control/JoinServlet.java 1
org/figure8/join/control/UserContainer.java 1
org/figure8/join/control/action/AssemblyActions.java 1
org/figure8/join/control/action/LoginAction.java 1
org/figure8/join/control/action/ParameterValueActions.java 4
org/figure8/join/control/action/PermissionActions.java 1
org/figure8/join/control/action/ResourceVersionActions.java 1
org/figure8/join/control/form/AssemblyForm.java 1
org/figure8/join/control/form/BuildForm.java 1
org/figure8/join/control/form/ConsumerForm.java 1
org/figure8/join/control/form/DeliverableForm.java 1
org/figure8/join/control/form/EISMappingForm.java 1
org/figure8/join/control/form/EnvironmentMappingForm.java 1
org/figure8/join/control/form/MailingListForm.java 1
org/figure8/join/control/form/ParameterForm.java 1
org/figure8/join/control/form/PermissionForm.java 2
org/figure8/join/control/form/QuartzCronForm.java 1
org/figure8/join/control/form/SetupForm.java 1
org/figure8/join/control/form/UserForm.java 1
org/figure8/join/control/taglib/AjaxAnchorsTag.java 2
org/figure8/join/core/EntityObject.java 1
org/figure8/join/core/persistence/HibernateXmlDatabinder.java 1
org/figure8/join/services/notification/SubscribersNotifierJMSAdapter.java 1
org/figure8/join/services/notification/im/XMPPNotifier.java 1
org/figure8/join/services/remoting/beans/RemoteMessage.java 1
org/figure8/join/services/remoting/beans/RemoteResourceVersion.java 1
org/figure8/join/services/remoting/services/ParameterServiceImpl.java 1
org/figure8/join/services/remoting/services/ProcessControlServiceImpl.java 2
org/figure8/join/services/repository/AbstractStructuredRepository.java 1
org/figure8/join/services/repository/SimpleFileSystemRepository.java 2
org/figure8/join/services/repository/VFSRepository.java 2
org/figure8/join/services/scripting/ScriptLauncherAdapterSupport.java 1
org/figure8/join/services/scripting/ScriptLauncherJMSAdapter.java 3
org/figure8/join/services/scripting/ScriptLauncherQuartzAdapter.java 2
org/figure8/join/services/scripting/ant/tasks/SubstituteParametersTask.java 1
org/figure8/join/services/scripting/jsr223/JSR223ScriptLauncher.java 1
org/figure8/join/services/scripting/jsr223/JSR223ScriptLauncherJMSAdapter.java 1
org/figure8/join/services/scripting/ruby/RubyScriptLauncher.java 2
org/figure8/join/services/vcs/CVSAccessor.java 1
org/figure8/join/util/UnixCrypt.java 2
org/figure8/join/businessfacades/environment/ParameterManagerTest.java 2
org/figure8/join/businessfacades/environment/ResourceManagerTest.java 3
org/figure8/join/businessobjects/artifact/persistence/BuildDaoTest.java 1
org/figure8/join/businessobjects/environment/persistence/ResourceDaoTest.java 1
org/figure8/join/businessobjects/environment/persistence/VersionedResourceUpdateDaoTest.java 1
org/figure8/join/services/repository/SimpleFileSystemRepositoryTest.java 4
org/figure8/join/services/repository/VFSRepositoryTest.java 2
org/figure8/join/services/scheduling/QuartzCronInfoTest.java 2
org/figure8/join/services/scripting/ScriptLauncherTest.java 1
org/figure8/join/services/security/PermissionResourceResolverStub.java 3

org/figure8/join/businessobjects/security/persistence/JdbcUserDao.java

Violation Line
Avoid unused local variables such as 'rows' - details... 253

org/figure8/join/control/AccessControlFilter.java

Violation Line
Avoid empty catch blocks - details... 121

org/figure8/join/control/DownloadServlet.java

Violation Line
Avoid empty catch blocks - details... 143
Avoid empty catch blocks - details... 149
Avoid empty catch blocks - details... 151

org/figure8/join/control/I18nStrutsBundleAdapter.java

Violation Line
Avoid empty catch blocks - details... 124
Avoid empty catch blocks - details... 133

org/figure8/join/control/JoinServlet.java

Violation Line
Avoid empty try blocks - details... 43

org/figure8/join/control/UserContainer.java

Violation Line
Avoid unused imports such as 'java.util.Collection' - details... 24

org/figure8/join/control/action/AssemblyActions.java

Violation Line
Avoid unused imports such as 'org.figure8.join.businessobjects.environment.Deployment' - details... 25

org/figure8/join/control/action/LoginAction.java

Violation Line
These nested if statements could be combined - details... 84

org/figure8/join/control/action/ParameterValueActions.java

Violation Line
Avoid unused local variables such as 'id' - details... 260
Avoid unused method parameters such as 'environmentKey' - details... 338
Avoid unused method parameters such as 'parameterName' - details... 338
Avoid unused private methods such as 'loadHistoricalValues(String,String)' - details... 338

org/figure8/join/control/action/PermissionActions.java

Violation Line
These nested if statements could be combined - details... 286

org/figure8/join/control/action/ResourceVersionActions.java

Violation Line
Avoid unused imports such as 'java.lang.reflect.Constructor' - details... 36

org/figure8/join/control/form/AssemblyForm.java

Violation Line
These nested if statements could be combined - details... 197

org/figure8/join/control/form/BuildForm.java

Violation Line
These nested if statements could be combined - details... 208

org/figure8/join/control/form/ConsumerForm.java

Violation Line
Avoid empty if statements - details... 209

org/figure8/join/control/form/DeliverableForm.java

Violation Line
These nested if statements could be combined - details... 197

org/figure8/join/control/form/EISMappingForm.java

Violation Line
Avoid unused private fields such as 'gatewayIdStr' - details... 47

org/figure8/join/control/form/EnvironmentMappingForm.java

Violation Line
These nested if statements could be combined - details... 121

org/figure8/join/control/form/MailingListForm.java

Violation Line
These nested if statements could be combined - details... 168

org/figure8/join/control/form/ParameterForm.java

Violation Line
These nested if statements could be combined - details... 72

org/figure8/join/control/form/PermissionForm.java

Violation Line
Avoid unused imports such as 'java.util.List' - details... 29
These nested if statements could be combined - details... 205

org/figure8/join/control/form/QuartzCronForm.java

Violation Line
Avoid unused private fields such as 'log' - details... 45

org/figure8/join/control/form/SetupForm.java

Violation Line
These nested if statements could be combined - details... 323

org/figure8/join/control/form/UserForm.java

Violation Line
These nested if statements could be combined - details... 142

org/figure8/join/control/taglib/AjaxAnchorsTag.java

Violation Line
Avoid empty catch blocks - details... 97
These nested if statements could be combined - details... 159

org/figure8/join/core/EntityObject.java

Violation Line
Overriding method merely calls super - details... 75

org/figure8/join/core/persistence/HibernateXmlDatabinder.java

Violation Line
Avoid unused imports such as 'net.sf.hibernate.SessionFactory' - details... 23

org/figure8/join/services/notification/SubscribersNotifierJMSAdapter.java

Violation Line
Avoid unnecessary return statements - details... 179

org/figure8/join/services/notification/im/XMPPNotifier.java

Violation Line
Avoid empty catch blocks - details... 274

org/figure8/join/services/remoting/beans/RemoteMessage.java

Violation Line
Avoid unused private fields such as 'release' - details... 39

org/figure8/join/services/remoting/beans/RemoteResourceVersion.java

Violation Line
Avoid unused private fields such as 'creationDate' - details... 32

org/figure8/join/services/remoting/services/ParameterServiceImpl.java

Violation Line
Avoid unused private fields such as 'log' - details... 38

org/figure8/join/services/remoting/services/ProcessControlServiceImpl.java

Violation Line
Avoid unused imports such as 'org.figure8.join.core.DuplicateEntityException' - details... 17
Avoid unused local variables such as 'deployment' - details... 201

org/figure8/join/services/repository/AbstractStructuredRepository.java

Violation Line
Avoid empty catch blocks - details... 87

org/figure8/join/services/repository/SimpleFileSystemRepository.java

Violation Line
Avoid empty catch blocks - details... 247
Avoid empty catch blocks - details... 249

org/figure8/join/services/repository/VFSRepository.java

Violation Line
Avoid empty catch blocks - details... 268
Avoid empty catch blocks - details... 270

org/figure8/join/services/scripting/ScriptLauncherAdapterSupport.java

Violation Line
Avoid unused imports such as 'org.figure8.join.services.scripting.persistence.ScriptLogInfoDao' - details... 23

org/figure8/join/services/scripting/ScriptLauncherJMSAdapter.java

Violation Line
Avoid unused imports such as 'org.figure8.join.core.Configurable' - details... 17
Avoid unused local variables such as 'done' - details... 171
Avoid unnecessary return statements - details... 174

org/figure8/join/services/scripting/ScriptLauncherQuartzAdapter.java

Violation Line
Avoid unused local variables such as 'done' - details... 145
Avoid unnecessary return statements - details... 147

org/figure8/join/services/scripting/ant/tasks/SubstituteParametersTask.java

Violation Line
Avoid modifying an outer loop incrementer in an inner loop for update expression - details... 266

org/figure8/join/services/scripting/jsr223/JSR223ScriptLauncher.java

Violation Line
These nested if statements could be combined - details... 139

org/figure8/join/services/scripting/jsr223/JSR223ScriptLauncherJMSAdapter.java

Violation Line
Avoid unused private fields such as 'launcher' - details... 30

org/figure8/join/services/scripting/ruby/RubyScriptLauncher.java

Violation Line
Avoid unused local variables such as 'value' - details... 105
Avoid empty catch blocks - details... 108

org/figure8/join/services/vcs/CVSAccessor.java

Violation Line
Avoid empty catch blocks - details... 116

org/figure8/join/util/UnixCrypt.java

Violation Line
An empty statement (semicolon) not part of a loop - details... 185
Avoid unused method parameters such as 'chars_in' - details... 410

org/figure8/join/businessfacades/environment/ParameterManagerTest.java

Violation Line
Avoid unused imports such as 'org.figure8.join.businessobjects.environment.Parameter' - details... 18
Avoid unused imports such as 'org.figure8.join.businessobjects.environment.ParameterValue' - details... 19

org/figure8/join/businessfacades/environment/ResourceManagerTest.java

Violation Line
Avoid unused imports such as 'org.figure8.join.businessobjects.environment.Gateway' - details... 19
Avoid unused imports such as 'org.figure8.join.businessobjects.environment.Service' - details... 20
Avoid unused imports such as 'java.util.List' - details... 25

org/figure8/join/businessobjects/artifact/persistence/BuildDaoTest.java

Violation Line
No need to import a type that's in the same package - details... 20

org/figure8/join/businessobjects/environment/persistence/ResourceDaoTest.java

Violation Line
Avoid unused imports such as 'org.figure8.join.businessobjects.environment.ResourceType' - details... 23

org/figure8/join/businessobjects/environment/persistence/VersionedResourceUpdateDaoTest.java

Violation Line
Avoid empty catch blocks - details... 104

org/figure8/join/services/repository/SimpleFileSystemRepositoryTest.java

Violation Line
Avoid empty catch blocks - details... 132
Avoid empty catch blocks - details... 134
Avoid empty catch blocks - details... 198
Avoid empty catch blocks - details... 200

org/figure8/join/services/repository/VFSRepositoryTest.java

Violation Line
Avoid empty catch blocks - details... 173
Avoid empty catch blocks - details... 175

org/figure8/join/services/scheduling/QuartzCronInfoTest.java

Violation Line
Avoid unused local variables such as 'cronInfo' - details... 54
Avoid unused local variables such as 'cronInfo' - details... 64

org/figure8/join/services/scripting/ScriptLauncherTest.java

Violation Line
Avoid unused imports such as 'org.figure8.join.services.scripting.ant.AntScriptLauncherTest' - details... 25

org/figure8/join/services/security/PermissionResourceResolverStub.java

Violation Line
Avoid unused imports such as 'java.util.Map' - details... 19
Avoid unused imports such as 'java.util.HashMap' - details... 21
These nested if statements could be combined - details... 77